Closed dgelessus closed 10 months ago
I'm not 100% sure if this is connected, but Maurus noticed an issue with Zandi today and dgelessus noticed some similarities. In the cleft, Zandi will no longer speak to you when you approach. If you exit his region, we will start to see a huge flood of messages in network.log. This happens on both dirtsand and MOSS (minkata alpha shard), provided you are using the modern H'uru client. network.0.log attached.
@Mirphak reminded me that he has a similar problem with excessive network messages spamming the network log (although that one only occurs in multiplayer). He tracked his problem down to #1429. Reverting that PR also fixes the issues I described here, so it seems that all of these problems have the same cause.
The actual commit that causes it is 4ef380f10fef7523761c73bc4cb2aeec68fac6fd, but even knowing that, this will be difficult to figure out. I'm guessing the removal of the implicit conversion changed something in a way that still compiles, but no longer behaves as it should.
To reproduce:
After this point, the bucket train glitches out in various ways, often making the puzzle impossible to complete. Glitches I've observed so far:
While debugging this, I also noticed that the bucket train causes a lot of network messages in certain cases. Not sure if these are related to the glitches.
plNotifyMsg
s (plus TestAndSet messages) for tldnBucketBrain.py. You can see this in network.log.tldnBucketAtEntry
flips back and forth between -1 and the correct bucket number, multiple times per second. If the bucket train is running, this only happens for a short time, but if a bucket is stopped at the "entry point", this happens constantly, until you link out and back in. You can see this in OLD_ASYNC_LOG.log and in the debug output (when running plClient with a debugger).Possibly related: #962