search

H-uru / Plasma

Cyan Worlds's Plasma game engine
http://h-uru.github.io/Plasma/
GNU General Public License v3.0
202 stars 80 forks source link

Fix ahnyQuab ogg decompression crashes. #1507

Closed Hoikas closed 9 months ago

Hoikas commented 9 months ago

This issue was introduced when hsStream::Close() was removed in favor of RAII in #1448. Unfortunately, the patcher is handing off files before it deletes the patcher stream, which causes race conditions around zlib decompression not being complete. We need to explicitly close the underlying stream before performing any handoffs to prevent crashes.

Fixes #1506

dpogue commented 9 months ago

Can confirm that this allowed me to patch the entire client data set from TrollLand with no issues.