colincornaby
commented
8 months ago Going to leave some feedback in since I do spend a lot of time reading and doing some work on this pipeline. I'll also add that in since code style is a preference - I'll add my feedback but it's not necessarily representative of everyone.
Two general things:
- Any code changes to this file need to be pretty well reviewed in since this is an active pipeline - and may need to be retested depending on the scope of the changes. So I personally tend to be more skeptical of changes made for style only reasons. The original code might not be messy, but it also is proven to work well. (Unless it hasn't, and in that case then it might need some updating.)
- It looks like a lot more commits have been added to this PR in the time since it was opened. There are a few PRs like that (like the Metal one) - but the commits should probably reach a conclusion or this PR should be brought back to a draft. It's more overhead to keep re-reviewing as commits are added.
jfmherokiller
these changes make the code a bit easier to read at a glance