search

H-uru / Plasma

Cyan Worlds's Plasma game engine
http://h-uru.github.io/Plasma/
GNU General Public License v3.0
202 stars 80 forks source link

max 2024 fixes #1532

Closed jfmherokiller closed 7 months ago

jfmherokiller commented 7 months ago

this set of changes makes the 3ds max plugin load under 2024 however only loading was tested.

Hoikas commented 7 months ago

FWIW, the H-uruMachineUser/3dsMaxSDK repo has the 2023 and 2024 SDKs available for use in CI.

dpogue commented 7 months ago

FWIW, the H-uruMachineUser/3dsMaxSDK repo has the 2023 and 2024 SDKs available for use in CI.

This doesn't run on PRs or forks due to token permissions (regarding SDK licensing), but yes it will be easy to start making builds of these automatically once this is merged.

I think I have the token set up in my fork, so I can grab this branch and give it a build if we want to see the compiled result before merging.

jfmherokiller commented 7 months ago

from tests it seems that 2022 and 2023 do not like how i creatively handled the progress bar and on 2023 it doesnt like the matrix fix

dpogue commented 7 months ago

I ran this with the full matrix of 3DS Max versions and it's all passing now: https://github.com/dpogue/Plasma/actions/runs/7041786861