search

H-uru / Plasma

Cyan Worlds's Plasma game engine
http://h-uru.github.io/Plasma/
GNU General Public License v3.0
202 stars 80 forks source link

Decouple pnAsyncCore from some protocol and game logic code #1533

Closed dgelessus closed 7 months ago

dgelessus commented 7 months ago

The AsyncSocket code had one specific assumption about the network protocol hardcoded - this fixes that. (I assume the server-side AsyncSocket code needs to care about this, but the client-side code doesn't.)

Also converts a bunch of LogMsg calls outside of pnAsyncCore to more appropriate calls. This also moves the log messages from OLD_ASYNC_LOG.log to more useful log files (e. g. VaultClient.log now actually contains all the vault log messages!).

tldr: Eliminates direct dependencies on pnAsyncCore from places that don't need them.

Hoikas commented 7 months ago

Is there anything else you wanted to do here, @dgelessus

dgelessus commented 7 months ago

No, this PR is complete from my end.