search

H-uru / Plasma

Cyan Worlds's Plasma game engine
http://h-uru.github.io/Plasma/
GNU General Public License v3.0
205 stars 81 forks source link

Commit 93d8c2c broke CMake on VS 17.9.5 #1577

Closed trebonian closed 6 months ago

trebonian commented 6 months ago

I updated Visual Studio to 17.9.5 (Free version) - and also did a pull on this repository - so I don't know for sure if the the older 17.9.4 works with the new vcpkg.

I reverted this commit and everything rebuilds ok.

The error I get when I run with the commit in is:

image

image

I think I need to do some VS magic to update the "vcpkg" submodule in my local repo. I am not sure how to do this.

Let me know if there is more that I can capture if you can't reproduce this

trebonian commented 6 months ago

I figured out how to do a "git submodule update" inside the VS Project. This fixed the issue...

dpogue commented 6 months ago

Hmm, we have code in CMake to setup the submodules if they don't exist, but nothing to bring them up to date if they're not. I'm not sure if there's even a good way to detect that situation and warn about it... 🤔

Glad to hear you got it working!

trebonian commented 6 months ago

All I had to do was clone into an empty repo, and stop it after git.exe was in the new environment.

I then set the path to the new git.exe and ran “git submodule update” when my current directory was the original Plasma.

I suspect that you could run it in place but it might wipe itself out when the update is done

Get Outlook for iOShttps://aka.ms/o0ukef

From: Darryl Pogue @.> Sent: Thursday, March 28, 2024 1:04:45 AM To: H-uru/Plasma @.> Cc: Barry Silverman @.>; State change @.> Subject: Re: [H-uru/Plasma] Commit 93d8c2c broke CMake on VS 17.9.5 (Issue #1577)

Hmm, we have code in CMake to setup the submodules if they don't exist, but nothing to bring them up to date if they're not. I'm not sure if there's even a good way to detect that situation and warn about it... 🤔

Glad to hear you got it working!

— Reply to this email directly, view it on GitHubhttps://github.com/H-uru/Plasma/issues/1577#issuecomment-2024400988, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAACX3H73JROKGWOLXDFPVLY2OQG3AVCNFSM6AAAAABFL3S6DSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRUGQYDAOJYHA. You are receiving this because you modified the open/close state.Message ID: @.***>