H-uru / Plasma

Cyan Worlds's Plasma game engine
http://h-uru.github.io/Plasma/
GNU General Public License v3.0
203 stars 80 forks source link

FindPhysX should search specific lib names first #1598

Closed dpogue closed 1 month ago

dpogue commented 1 month ago

This resolves an issue where PhysX libraries installed with generic names at a system level were being found preferentially ahead of the ones created by vcpkg.

Hoikas commented 1 month ago

Have you tried modifying the find_library() calls to pass the NO_SYSTEM_ENVIRONMENT_PATH argument instead?

dpogue commented 1 month ago

Have you tried modifying the find_library() calls to pass the NO_SYSTEM_ENVIRONMENT_PATH argument instead?

But we'd only want to do that if USE_VCPKG is set, right?

Hoikas commented 1 month ago

It looks like the find module is testing if(VCPKG_TOOLCHAIN) in places.

dpogue commented 1 month ago

Okay, will give that a shot

dpogue commented 1 month ago

Updated and seems to be working