search

H-uru / Plasma

Cyan Worlds's Plasma game engine
http://h-uru.github.io/Plasma/
GNU General Public License v3.0
205 stars 80 forks source link

Fix Relto Book Share Clickspam #1606

Open Attagoat opened 1 month ago

Attagoat commented 1 month ago

I am not a part of the guild of greeters although I like helping people who are new to the Cavern.

One of the issues that new people seem to do constantly is spam click the relto book on the person that they are sharing the relto book with.

This causes the relto book to flash on screen for the other person making it hard for them to link to relto.

Would it be possible to fix this by disabling spamclicking when the book has been shared with a player?

-Atticus "Attagoat" Kaphaem.

Deledrius commented 1 month ago

Great suggestion! That sounds like something that should be fixable.

dpogue commented 1 month ago

This comment feels potentially relevant here: https://github.com/H-uru/Plasma/blob/2a60d41e4ac21937bf9d29cc53d6e5a476725787/Sources/Plasma/PubUtilLib/plAvatar/plAvatarMgr.cpp#L373-L376

So when a new share is triggered, it kills the old one and starts a new one, which is what causes the book GUI to keep spamming up.

There's a plCoopCoordinator::IsActiveForReal() method that gets used in a bunch of other spots in the avatar mgr to determine if a share is still in progress, so maybe we can find a way to use that to prevent sharing when an active share is already happening?

Attagoat commented 1 month ago

Just another suggestion to add to this idea: Would it be possible to send a message to let players know that the sharing of the relto book was accepted/denied? like if the avatar they are sharing the relto book with clicks off of the relto book the game lets them know.