search

H-uru / PlasmaShop

Swiss army knife for Plasma file hacking
GNU General Public License v3.0
17 stars 17 forks source link

Installer doesn't wait for user's yes/no restart choice before restarting #65

Closed ZarothYe closed 2 years ago

ZarothYe commented 2 years ago

When the install finishes, Windows immediately starts the "I'm closing everything so I can restart" process without any interaction from the user. If you cancel this process, only then can you see the intended restart choice screen for the user, but by this point Windows may have already forced some applications closed. Very unfortunate.

image

Confirmed by both myself and Briggs.

If, after cancelling, you then select the "Yes, please restart now" and click "Finish", nothing happens. No restart.

zrax commented 2 years ago

It looks like the VS Runtime installer was scheduling a reboot before Setup had the opportunity to prompt for it... I've uploaded a new installer (2022.05.19-1) which should resolve the issue by suppressing the VS Runtime installer's reboot request.

ZarothYe commented 2 years ago

The icons and the wizard look a bit different with the new version, but unfortunately the unwanted surprise restart still happens. The Yes/No radio button choice on the "Finish" step (after a frantic cancel of the restart) appears to be gone, too, which I'm not sure was intended?

zrax commented 2 years ago

The icons are different because I updated to a newer version of InnoSetup... Additionally, I assume the yes/no choice will probably only show up once per system, since the changes that trigger InnoSetup to prompt you for restart (things like the file associations) have already been made when you run the installer a second time.

Although it's possible InnoSetup itself has a bug, I somehow doubt it since updating to the newer version didn't fix anything. And since the restart happened while the reboot prompt was being shown the first time, I have to assume it's not coming from InnoSetup itself (i.e. that it's coming from the VS Runtime installer, or some other pending update on your system that the runtime installer is somehow triggering). I can't reproduce this behavior with either the old nor the new installer on my system, so I'm just going to leave this open for input in case others have ideas.

zrax commented 2 years ago

Upon closer examination, it looks like the installer may not have actually been built with my fix... Please try the newly uploaded 2022.05.19-2 release exe and see if it fixes the issue.

ZarothYe commented 2 years ago

That did it! No surprise restarts! 🥳