search

H-uru / korman

Blender plugin for creating ages for Cyan Worlds' proprietary Plasma engine and its open source variant, CyanWorlds.com Engine.
GNU General Public License v3.0
34 stars 17 forks source link

Removed the `OrderedDict`s #400

Closed 1Codealot closed 9 months ago

1Codealot commented 9 months ago

Relates to this issue: https://github.com/H-uru/korman/issues/398

I also have added type annotations :)

1Codealot commented 9 months ago

Cool, thanks for reviewing! I'll do those now!

1Codealot commented 9 months ago

What do you think now?

1Codealot commented 9 months ago

It's really great to see new contributors 😁

You're welcome!

Deledrius commented 9 months ago

Thanks for joining in to make Korman better! :)

1Codealot commented 9 months ago

Thanks for the reviews, I'll change them in a bit!!

1Codealot commented 9 months ago

bruh i did a typo in the commit 💀

Deledrius commented 9 months ago

bruh i did a typo in the commit 💀

No problem, you can amend the commit to edit the commit message. :)

1Codealot commented 9 months ago

No problem, you can amend the commit to edit the commit message. :)

Sorry I can't seem figure out how (I'm doing this on the remote vscode on GH at the moment)

Deledrius commented 9 months ago

It looks like it is possible, but a bit convoluted to do in VSCode (https://stackoverflow.com/questions/63882369/can-i-amend-a-commit-made-with-vscode-to-github-repo).

That's alright. I, or one of the other maintainers, can fix the commit message. Don't worry about it. :)

1Codealot commented 9 months ago

Done moving the from __future__ import annotations to the top!

1Codealot commented 9 months ago

I think we need to be using Any, which means "any type".

Right yep, will do!

1Codealot commented 9 months ago

Done!