H-uru / libhsplasma

Cross-platform Plasma data and network library
GNU General Public License v3.0
32 stars 30 forks source link

CMake visibility changes break PyHSPlasma on Python < 3.9 #248

Closed dpogue closed 2 years ago

dpogue commented 2 years ago

Essentially, PyInit_PyHSPlasma isn't marked as visible, so the module initialization fails.

This is fixed in Python >= 3.9 because they added visibility attributes to the PyMODINIT_FUNC macro, however some of us are still building with Python 3.7 to run korman on Linux with Blender 2.79 (which depends on Python 3.7).

Based on how libHSPlasma and libHSPlasmaNet are doing things, I imagine there's some sort of PYHSPLASMA_EXPORT thing that could be added here to make it visible, but I don't know enough about where and how CMake is defining these macros to be sure of that...