search

H-uru / moul-assets

A collection of fan-maintained game assets and sources used by Myst Online.
Other
21 stars 17 forks source link

Journals Missing UI Covers #211

Open patmauro opened 1 year ago

patmauro commented 1 year ago

The following journals currently break Uru design language due to missing covers in the UI, which seems to be due to cover definitions missing from their LOC files. In every case, a cover texture does exist for this book already (at least as part of another texture), but was not linked to the UI object - in theory, each of these cases should therefore be fairly trivial to fix:

(Not including the Kalamee journals or Naybree science log here, as these are special cases that don't really fall under the umbrella of the particular issue I am describing here.)

The behavior of all books objects in Uru needs to be consistent across the board, otherwise they risk breaking the gameplay & design language established by the base game, which in turn breaks immersion.

DoobesURU commented 1 year ago

Huh. Wonder how all that slipped past testing. I'll have a look at the PRPs and LOC files and see if I can fix all that.

EDIT: For Tiam and Elonin, those journals appear to be set to be automatically open, so they have no covers by Dulcamara's and/or ametist's choice. Similarly, the journals from Chiso mentioned are set up the same way: no GUI cover provided and started open per their writers.

Given Tiam, Elonin, and those explorer journals are not technically my work, I will leave it up to their respective builder/maintainer and submitters on if they want to add them.

Serene is the only exception as it appears Andy did have a GUI cover for it at one time judging by the old Python scripts used in the PAK file, but it was lost along the way. I have located the higher res version of the cover used on the current clickable mesh that Andy likely used and will be modifying Serene to what I believe Andy intended it to be, with the proper GUI cover.

patmauro commented 1 year ago

The problem, as I see it, is that "auto open" behavior is itself not consistent with established Uru behavior - either way, this is going to read as a mistake rather than an intentional design choice. So, I would strongly encourage the writers of each of these journals to make the needed adjustments to bring these journals "up to compliance" as it were, with properly defined covers.

Will make my case with the creators in question, and see if we can't convince folks to make changes bringing these "up to compliance" as it were.

patmauro commented 1 year ago

All creators have approved these changes; many of the fixes are already live on OU's m-a test shard. Once all the relevant PRs are submitted to h-uru/moul-assets, this issue can be closed.

patmauro commented 1 year ago

Just re-reviewed; as of the 2023Q1 Update all of these have been fixed on MOULa and several have been fixed here in H'uru/moul-assets. The only remaining holdouts on H'uru are due to the following:

Hoikas commented 1 year ago

212 is currently broken as submitted and is awaiting revisions.

patmauro commented 1 year ago

Once (1) Chiso gets a supplemental update that adds those last 2 covers and (2) #212 is completed, then I think we are good to close this ticket - since Elonin & Bahvahnter are not part of this repo yet, they are technically out of scope here. Instead, I'll add a reminder on their corresponding PRs to account for this.

patmauro commented 1 year ago

@DoobesURU - do you plan to drop a PR for your 2023Q3 adjustments to Chiso with the shelf, etc? If that includes the Dulcamara & Carl Palmer journal fixes as well, then this issue can probably be marked "solved."

patmauro commented 1 week ago

I'll have to double-check Chiso once the ongoing "Purge" is done, but as long as Serene & any RP stuff in Chiso is removed, that should hypothetically close this ticket. Will re-check and advise.