search

H-uru / moul-assets

A collection of fan-maintained game assets and sources used by Myst Online.
Other
20 stars 16 forks source link

Rainy Cleft items bound to Bahro Scene (Firepit & Chair) #228

Open patmauro opened 1 year ago

patmauro commented 1 year ago

As noticed by @Traveler263 - The texture for Zandi's firepit coals is missing in the mainstream version of Rainy Cleft. This seems to be due to a paging issue - these coals appear correctly during the version of Rainy Cleft loaded for the "bahro" sequence, but then never load again on any subsequent Rainy Cleft visits.

Expected (mockup): image

Actual: image

Sidenote - the chair: "Pre-Bahro" Rainy Cleft will ALSO load a side chair next to the fire pit. Post-Bahro, Rainy cleft does not load the firepit coals OR this chair. I'd say it probably makes IC sense for this chair to have been "put away" by Zandi, so likely there are two paging adjustments that need to be made: pre-bahro should not load this chair, and post-bahro should not UN-load the coals. Edit: Confirmed these are part of a set and should load together. image

DamnBriggsy commented 1 year ago

The relto page that usually lives next to the ruined scope suffers from this problem as well. image As far as the chairs go, I'd be curious what was the intended behavior. I could see a valid argument for either keeping them out or putting them away.

patmauro commented 1 year ago

The relto page that usually lives next to the ruined scope suffers from this problem as well.

You're right, I didn't notice that. I wonder if that shows up in the "pre-bahro" rainy cleft. IIRC that's an SDL that's off by default, right? Like, I know that page is missing by default on Destiny, etc, even in Sunny Cleft. So perhaps something is blocking that sdl from "translating" to rainy cleft properly in the paging file change.

As far as the chairs go, I'd be curious what was the intended behavior. I could see a valid argument for either keeping them out or putting them away.

Probably would be best to check the paging file(s) to know for sure - the presence of anything like a different shadow for the rainy version, etc would immediately settle the debate and prove the chair is supposed to be present in the rain. Otherwise, the best we can do is guess - since the other chair is missing too, my hunch is it makes sense for it to be "taken inside" for the rain, but if there's any evidence that it was supposed to be there, that definitely supersedes any hunches. EDIT: The shadows on the firepit rocks and the shadows on the chair are baked into the same texture file. Given the behavior in the bahro scene page, this would seem to confirm the intended behavior: the firepit rocks and the chair are intended to be part of a set, and the chair does not get put away.

DamnBriggsy commented 1 year ago

I wonder if that shows up in the "pre-bahro" rainy cleft.

I remember testing this specifically before, but I can't find the discussion. If I recall correctly, the page is missing before the bahro seen SDL is flipped (flymode out of cleft before triggering the cutscene at the top of the ladder).

patmauro commented 9 months ago

I wonder if that shows up in the "pre-bahro" rainy cleft.

I remember testing this specifically before, but I can't find the discussion. If I recall correctly, the page is missing before the bahro seen SDL is flipped (flymode out of cleft before triggering the cutscene at the top of the ladder).

OK, so I confirmed this isn't connected to the Bahro scene specifically, but is one of several discrepancies that seem to exist between how Sunny & Rainy Cleft are loaded in general. For organizational purposes I'll probably branch these off into a separate ticket since it's a slightly different problem.

patmauro commented 9 months ago

So there are actually lots of different issues going on here. For organizational purposes I have cleaned up this ticket and have broken this up into 3 tickets to more clearly document the issues here:

  1. Rainy Cleft items bound to Bahro Scene (Firepit & Chair) [this item]
  2. https://github.com/H-uru/moul-assets/issues/248 (general differences not due to bahro scene)
  3. https://github.com/H-uru/moul-assets/issues/249