H-uru / moul-assets

A collection of fan-maintained game assets and sources used by Myst Online.
Other
20 stars 16 forks source link

Bahro Cave: Only Garrison's Pole Fully Animates #246

Open patmauro opened 10 months ago

patmauro commented 10 months ago

Noticed this (unrelated!) issue while verifying https://github.com/H-uru/moul-assets/pull/244:

_(Since this may be misleading - the title is referring to how much of the physical pole animates, not whether the animation completes.)_

3/4 of the poles in Bahro Cave only feature the snow animation in the center of the pole, but not the "cap" (or bottom). However, Garrison's pole also features animation in the cap: image

At first, it seems like the Garrison pole is the one that is incorrect, but when we compare to the poles in Relto, the entire pole always animates. image

First, need to determine: Which was the intended design? If "whole pole" is the correct design, then the other 3 poles in Bahro Cave need to be fixed. However, if "center only" is the correct design, then the Garrison pole needs to be fixed in Bahro Cave, and then all four poles need to also be corrected in Relto.

See if there are any clues in texture, code, etc that might give a better clue as to which the "correct" design is. There may be hints in the texture files.

dpogue commented 10 months ago

Is it consistent between the blue and orange Bahro caves (i.e., when you initially collect the poles vs when you return them)?

patmauro commented 10 months ago

Is it consistent between the blue and orange Bahro caves (i.e., when you initially collect the poles vs when you return them)?

Yup: bahrocave

My hunch so far is that it's supposed to be only the middle bit on those poles that animates, and this is a case of a good old fashioned art mismatch between ages. I'll dig through textures & other art sources to try to confirm this theory.

EhrenCG commented 10 months ago

I feel pretty confident saying the entire poles are supposed to be lit up. It's what the history suggests. BahroPoleTops

patmauro commented 10 months ago

I feel pretty confident saying the entire poles are supposed to be lit up. It's what the history suggests. BahroPoleTops

Confirmed - It definitely seems like all four are supposed to be lit up. That settles that I think!

This is actually pretty good news: (a) this limits the scope of this issue to just the bahro cave, which is nice, and (b) the solution we're looking for probably lies in CC.

Hazado commented 10 months ago

The mesh itself has had the snow texture removed from the top part of the poles in the moula bahro caves. Screenshots from blender imports

The snow mesh applied to the URU CC bahro cave image

The snow mesh applied to the Moula bahro Cave image

Hazado commented 10 months ago

So I fixed this in a local test by importing the drawable span from uru CC and nulling the materials we dont need. Move where the draw interface is pointing and bam fixed mesh. Increases the size of the file a little but yes the Uru CC mesh will fix the issue here