Bugs with CommandGroups

[Ovyerus]

CommandGroups don't get added into the CommandHolder.modules[module_name] list. Sometimes, a module will fail to load due to the following error, which appears to be caused by a CommandGroup.

Traceback (most recent call last):
  File "/home/rslsync/OvyBot/amethyst.py", line 232, in on_message
    await self.holder.run_command(ctx)
  File "/home/rslsync/OvyBot/utils/command_system.py", line 522, in run_command
    await cmd.run(ctx)
  File "/home/rslsync/OvyBot/utils/command_system.py", line 187, in run
    await self.func(self.cls, ctx, *args, **kwargs)
  File "/home/rslsync/OvyBot/modules/core.py", line 65, in module
    self.amethyst.holder.load_module(module_name)
  File "/home/rslsync/OvyBot/utils/command_system.py", line 481, in load_module
    self.aliases[alias] = self.commands[cmd.name]
KeyError: 'nickname'

[Martmists-GH]

Why did we decide to move away from ext.commands again?

[H3xadecimal]

Convenience purposes, also cause Ovy wanted to.

[Ovyerus]

Allows us to extend on it without too much hasse, and learning™

[Martmists-GH]

You can easily override the command class, which makes extending far easier. you could do something like

def command(*args, **kwargs):
    return discord.ext.commands.command(*args, cls=MyCommand, **kwargs)

[Ovyerus]

¯\_(ツ)_/¯

[Ovyerus]

Seems to be fixed.

[Ovyerus]

Key error bug still happening

[H3xadecimal]

Further testing required to replicate this error on my end, Will also look into it.

[H3xadecimal]

Error successfully replicated, not sure if that's a good thing. Entering debugging phase.

[Ovyerus]

Latest commit hopefully fixed this.

[Ovyerus]

k nvm its not, but it seems to be happening less often.