H7KZ / Disenchantment

New mechanics for minecraft vanilla gameplay. This plugin allows players to disenchant items and get the item's enchantments back.
https://www.spigotmc.org/resources/110741
1 stars 2 forks source link

So after i updated to v5.0.0 the disenchant cost has channged #10

Closed FearlessNite345 closed 2 weeks ago

FearlessNite345 commented 1 month ago

so on 4.0.0 it costed 15 for

Base Value: 10 Enchantments: Unbreaking (level 3), Repairing (level 2), Thrive (level 1) Multiplication Factor: 0.25

but on 5.0.0 it now costs 17 has something changed?

i didnt change the config values

H7KZ commented 1 month ago

Reviewed it, refactored it, fixed it, should be 18 xp :DDDDDD

base = 10, unbreaking = 3, repairing = 2, thrive = 1, multiplier = 0.25

Calculate: 10 + (1 1) = 11 base + (thrive multiplier) 11 + (2 1.25) = 13.5 base + (repairing multiplier) 13.5 + (3 1.5) = 18 base + (unbreaking multiplier)

In total 18xp

Will be fixed in v5.1.0 (also adding more custom plugin supports)

ejm554 commented 1 month ago

@H7KZ : Could you explain more about how the multiplier works in your example where you started out by saying that the multiplier = 0.25 ?:

... multiplier = 0.25

10 + (1 1) = 11 base + (thrive multiplier) 11 + (2 1.25) = 13.5 base + (repairing multiplier) 13.5 + (3 1.5) = 18 base + (unbreaking multiplier)

If I'm reading this example correctly, the multipliers in the three operations are 1, then 1.25, and then 1.5. How/why are these multipliers changing by factors of 4, 5, and 6, respectively?

When I read your list of starting values here (and in config.yml), it suggested to me that these were constants and shouldn't change. In other words, I would have assumed that the multiplier should always be 0.25, and never vary. Clearly, I'm misunderstanding.

H7KZ commented 4 weeks ago

With each enchantment the disenchantment gets progressively more expensive due to multiplier stacking up. With each iteration the multiplier adds it self to make the next enchantment more expensive.

So with 4 enchantments the multiplier of 0.4 will, at the final enchantment, be 1.6

  1. First Enchantment will be multiplied by 0.4
  2. Second enchantment will be multiplied by 0.8
  3. Third by 1.2
  4. Fourh by 1.6

If you feel this is somehow unbalanced or confusing at counting, please say so! It is easily changeable :)