search

H7KZ / Disenchantment

New mechanics for minecraft vanilla gameplay. This plugin allows players to disenchant items and get the item's enchantments back.
https://www.spigotmc.org/resources/110741
2 stars 2 forks source link

Issue with disenchanting #9

Closed FearlessNite345 closed 3 months ago

FearlessNite345 commented 3 months ago

I have given myself the "disenchantment.anvil" perm and im on 1.21 PaperMC when i try to place a item in the anvil with the book it flickers for one second in the output then goes away and i have not been able to track down any errors i can find i do use EcoEnchants if maybe its a issue with that

FearlessNite345 commented 3 months ago

Here is a video of said issue https://youtu.be/bw2bcJcuHTA

FearlessNite345 commented 3 months ago

Still guessing the issue is with EcoEnchants as i see you now added the warning back to the spigot page after you said it would work with it now

H7KZ commented 3 months ago

Yeah idk, will look into it when I have time. If you need it right away, you can open up a MR with fixes :D Otherwise wait, don't have much time

H7KZ commented 3 months ago

Would you please also include any console logs from the event? If there isn't some sort of easy explanation? I am currently on vacation and will be coming back in 2 days. Then I can really look into it. But there is problem with testing it really well... Eco is monetized, but is open-sourced and well... I only gave it a few minutes to try to compile but hell... there were some deps issues so I really didn't think about it :D I believed that it would work (of course it didn't -_- :DDD)

FearlessNite345 commented 3 months ago

So i have made a Fork of this repo and tried to play around with it to see if anything will work and i did come across that EcoEnchants handles the same anvil event and im wondering if its almost overriding yours ive not been able to get any errors or anything as i dont really think its a error i think its just EcoEnchants settings the anvil output to nothing nearly instant maybe im wrong but it would make since how it makes the book but then disappears

FearlessNite345 commented 3 months ago

https://github.com/Auxilor/EcoEnchants/blob/master/eco-core/core-plugin/src/main/kotlin/com/willfp/ecoenchants/mechanics/AnvilSupport.kt

FearlessNite345 commented 3 months ago

if needed i could send you my version of it just so you can test cause it does make it harder without having it

H7KZ commented 3 months ago

if needed i could send you my version of it just so you can test cause it does make it harder without having it

that would be absolutely amazing! :D

FearlessNite345 commented 3 months ago

Question do you have discord so i don't post it here and make it public for everyone

H7KZ commented 3 months ago

h7kz

H7KZ commented 3 months ago

Waiting for EcoEnchants to merge PR, otherwise this is marked as closed

https://github.com/Auxilor/EcoEnchants/pull/397