search

HABTec / public-dashboard

0 stars 1 forks source link

Added request page #2

Closed RihanaE closed 4 months ago

netlify[bot] commented 5 months ago

Deploy Preview for public-dashboard ready!

Name Link
Latest commit ffee1be73171e9574611b1264d039a328932008d
Latest deploy log https://app.netlify.com/sites/public-dashboard/deploys/663dd462b0b042000820143a
Deploy Preview https://deploy-preview-2--public-dashboard.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

redet-G commented 4 months ago

lgtm!

RihanaE commented 4 months ago

I have fixed both the dashboard and request form. Could you review it again and merge it?

On 10 May 2024, at 09:47, Redet Getachew @.***> wrote:

@redet-G approved this pull request.

In package.json https://github.com/HABTec/public-dashboard/pull/2#discussion_r1589983709:

@@ -9,18 +9,23 @@ "eject": "react-scripts eject" }, "dependencies": {

  • @.***/browser": "^4.3.3", Do we need this dependency anymore?

In src/App.js https://github.com/HABTec/public-dashboard/pull/2#discussion_r1589983759:

export default function App() {

  • return ;
  • return (
  • <Route path="/" element={} /> The default/index page should be the dashboard

— Reply to this email directly, view it on GitHub https://github.com/HABTec/public-dashboard/pull/2#pullrequestreview-2039350034, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2QWLTDXGUSUBYGK3VKVRALZBRURPAVCNFSM6AAAAABHG2HWXCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMZZGM2TAMBTGQ. You are receiving this because you authored the thread.