search

HABTec / public-dashboard

0 stars 0 forks source link

shareable link for each dashboard items #26

Closed RihanaE closed 2 weeks ago

netlify[bot] commented 2 weeks ago

Deploy Preview for public-dashboard ready!

Name Link
Latest commit 3d37822207d9fe3f4fc5d73fa0c3ccee32470ede
Latest deploy log https://app.netlify.com/sites/public-dashboard/deploys/66869a26deff3000080fb4ed
Deploy Preview https://deploy-preview-26--public-dashboard.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

RihanaE commented 2 weeks ago

On dashboard 'test2', there are items with an 'undefined' id, which result in being unable to access them. What do we do?

redet-G commented 2 weeks ago

If I remember correctly we have modified the code so that it uses _id property of the dashboard item in such cases.

redet-G commented 2 weeks ago

Additionally, you are still on the #5-adding_support_for_area_chart_type" branch. I am seeing a conflict on chart.js file. It is always advised to create a new feature branch for each of the pull requests and stay in sync with the main branch.

RihanaE commented 2 weeks ago

Okay, will do that in the future.

On 4 Jul 2024, at 11:48, Redet Getachew @.***> wrote:

Additionally, you are still on the #5 https://github.com/HABTec/public-dashboard/issues/5-adding_support_for_area_chart_type" branch. I am seeing a conflict on chart.js file. It is always advised to create a new feature branch for each of the pull requests and stay in sync with the main branch.

— Reply to this email directly, view it on GitHub https://github.com/HABTec/public-dashboard/pull/26#issuecomment-2208442179, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2QWLTGFMRGRNTOQSDCZ6O3ZKUD5XAVCNFSM6AAAAABKLA2KCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBYGQ2DEMJXHE. You are receiving this because you authored the thread.