HACKERALERT / Picocrypt

A very small, very simple, yet very secure encryption tool.
GNU General Public License v3.0
2.42k stars 145 forks source link

Comments are not encrypted (by default) and this is not mentioned in the program window #164

Closed hakavlad closed 1 year ago

hakavlad commented 1 year ago

README says "It's designed for maximal security, making absolutely no compromises security-wise", but comments are not encrypted by default and the user will not even be notified of this, unless he reads the README to a certain paragraph.

In my opinion, it would be good practice to notify users right in the program window that comments are not encrypted by default because not all users read the documentation beyond the first paragraph. This could reduce mortality among inattentive users.

HACKERALERT commented 1 year ago

Very good observation, thanks for pointing it out. Although I think most people are sensible enough not to put sensitive data in the comments field, I agree with you that adding something like a tooltip on hover would be a good failsafe. It would be a small change so I won't make a new release just for it, but I'll keep this issue open as a reminder to add the warning when I make the next release, whenever that may be. Thanks!

On Sat, Jun 10, 2023, 6:32 a.m. Alexey Avramov @.***> wrote:

README says "It's designed for maximal security, making absolutely no compromises security-wise", but comments are not encrypted by default and the user will not even be notified of this, unless he reads the README to a certain paragraph.

In my opinion, it would be good practice to notify users right in the program window that comments are not encrypted by default because not all users read the documentation beyond the first paragraph. This could reduce mortality among inattentive users.

— Reply to this email directly, view it on GitHub https://github.com/HACKERALERT/Picocrypt/issues/164, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALUMDTAUX4BPFHKD424AHV3XKREK3ANCNFSM6AAAAAAZBTC3EQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

HACKERALERT commented 1 year ago

Added this to the changelog for the next release, so I'll close it here to keep things clean and organized.