search

HACKERALERT / Picocrypt

A very small, very simple, yet very secure encryption tool.
GNU General Public License v3.0
2.42k stars 145 forks source link

Introduce test coverage #175

Closed SemanticBeeng closed 1 year ago

SemanticBeeng commented 1 year ago

Without test coverage for at least the main claims/features it is hard to trust for production use cases. Example: https://github.com/diba-io/carbonado/blob/main/tests/apocalypse.rs

Very valuable key features!

HACKERALERT commented 1 year ago

Yup, I agree with you that tests will be a good addition. However, how would tests work for Picocrypt, which is a GUI app?

SemanticBeeng commented 1 year ago

We could refactor the core functionality separate from UI.

HACKERALERT commented 1 year ago

Possibly, but that would be very difficult to do because the UI is tightly integrated with the core functions and decoupling it would probably introduce more bugs than it fixes.

SemanticBeeng commented 1 year ago

How would one know there are bugs unless there are tests to prove it? :-) Only half kidding. This tool claims powerful features we all need. But we can't rely on it for serious uses unless we can verify correctness.

HACKERALERT commented 1 year ago

Yeah no worries, I completely understand the concern. The tests would only cover a very specific set of cases, though, and most bugs occur in edge cases that can't be predicted and must be found through users using the software in the real world. Of course, I don't have much experience with code tests, so I'm not the best to speak for it.