HACKERCHANNEL / PSL1GHT

A lightweight PS3 SDK
www.psl1ght.com
MIT License
182 stars 67 forks source link

Various fixes and improvements to cgcomp #76

Closed zeldin closed 13 years ago

zeldin commented 13 years ago

cgcomp does not actually use libCg.so when the -a option is specified, so it makes no sense to require it.

zeldin commented 13 years ago

I fixed some bugs and added support for REP/BRK as well. Now I am able to assemble my Mandelbrot fragment program on Linux/PPC.

shagkur commented 13 years ago

Thanks alot for your fixes, additions and changes to it. i just commited it to the master.

zeldin commented 13 years ago

Hi shagkur.

It looks like you made some mistake when you applied my changes: The first line of CParser::ParseCond is supposed to be

token = ConvertCond(token,insn);

but on HACKERCHANNEL:master it appears as

token = ConvertCond(&token[1],insn);

which loses the first character of the condition.

It would probably have been simpler if you had just merged the commits instead of whatever you did now... :-/

zeldin commented 13 years ago

Also, the code token++; in the parsing of o[] registers in CFPParser::ParseMaskedDstReg seems to have been lost. Without this, the closing ] is not parsed, and so stuff like oCOLR will not work because ParseMaskedDstRegExt will get "](NE)" instead of "(NE)".

shagkur commented 13 years ago

Hi, sorry for the hassle. Yeah, i merged it manually and obv there happend some mistakes. Sorry again. It's fixed now.

zeldin commented 13 years ago

Looks all right now according to git diff -w. Thanks.