HAERUHAERU / mopimopi

24 stars 37 forks source link

Overlay never entering standby #14

Closed ghost closed 2 years ago

ghost commented 2 years ago

I have an issue where the overlay, after combat, never enters standby. I have standby mode enabled and the timer set to three minutes. I don't know what to provide in terms of logs or files, but ask and you shall receive.

2phite commented 2 years ago

I have the same issue. Happy to provide logs on request.

illegaler commented 2 years ago

I have the same problem

chernobog commented 2 years ago

Same issue to report. Seems like it will sleep correctly once per session, but then it stops activating the sleep display.

illegaler commented 2 years ago

The issue has been fixed https://github.com/HAERUHAERU/mopimopi/commit/df1433923b8b45c9be7c5f2b147a301fb6f43321 Exiting ACT and deleting the cache folder location in ~\AppData\Roaming\Advanced Combat Tracker The standby mode will now work properly

chernobog commented 2 years ago

Confirmed. Deleting "%userprofile%\AppData\Roaming\Advanced Combat Tracker\OverlayPluginCache\" has restored the standby functionality. Tiny downside, that does reset customizations to the overlay. Not a big deal to set them up again.

2phite commented 2 years ago

Following this change, the overlay now goes into standby while in combat. Tested on ACT version 3.6.0, which was updated after this fix. I deleted the folder %userprofile%\AppData\Roaming\Advanced Combat Tracker\OverlayPluginCache before testing, as mentioned above.

chernobog commented 2 years ago

I can't reproduce that. I've been attacking a Striking Dummy for over five minutes, and the overlay is still active.

sennematic commented 2 years ago

I also am having the issue where it enters standby during combat. To reproduce this error: 1) Enter any combat (ie: striking dummy) -- overlay works as normal 2) End combat 3) Enter a new combat -- parser will enter into standby from the timer based on the first combat instance. Overlay will show the correct total Raid DPS/Timer/Current Target but will stay in compact/standby mode where you cannot view individual results

Deleting the cache folder did not fix this issue for me, although it did let me get through 2 combats before the issue occurred

ghost commented 2 years ago

Same issue, @sennematic described it perfectly. I'll add that the overlay shows up again if you open its settings menu.

chernobog commented 2 years ago

I can confirm, I'm seeing that issue under the circumstances @sennematic describes.

illegaler commented 2 years ago

Yea, same issue.

cskampas commented 2 years ago

+1. Regression new as of the 5/14 change as far as I can tell.

There was a pr to add the instructions to clear cache more recently. I have done this, and the issue persists. The encounter timer will continue to tick up, but no information is displayed. Issue is isolated to mopimopi, act and other overlays display correctly

Based on info here, I will try disabling standby mode or putting it at a substantially longer timer than 3 minutes--let me see if that helps, not sure if it will--for now, until a fix is in.

HammerBag commented 2 years ago

I won't be able to test but looking at the code in process.js (which was updated to fix the original issue) it looks like it sets OnStopFlag to true arbitrarily if last combat is active. I think that needs to be moved into the else statement to solve the issue. I should be able to test this tonight (approx 11hrs after this post time) but if anyone else wants to take a crack at it, that's what seemed like the place to start when I looked at the code last night (but game was down so couldn't test any changes)

illegaler commented 2 years ago

The issue has been fixed, thanks to the quick work of HAERU :)

sennematic commented 2 years ago

Confirmed working after update :)

ghost commented 2 years ago

Also confirmed working! Closing the issue, thank you for the fix!