Go to Definition show all references, not just definition

[Ben-Mack]

Thank you for making this extension! Currently Go to definition (Ctrl+click) always show every code references to the function/variable, this makes navigating in code really hard. I've been using Sublime Text with MXS extension and its go to definition working perfectly, I'm switching to VSCode but this is a major set back for me. Please improve Go to definition to really show definition only, not references.

[Ben-Mack]

Hi @HAG87, Is this the intended behavior? If not, please left this issue as open so someone could contribute this on future. It'd be even better if you could reference to where this change should be made

[HAG87]

For simplicity, it is intended behavior. Didn't quite understand what you mean by reference, you mean it jumps to a call or implementation instead of the definition? Currently, definitions are provided this way:

• First, check if there are available document symbols that match the request (the symbol usually references the definition, this is the case for functions and named scopes in general, variables are partially implemented, for perfomance and the loosely-typed nature of Maxscript that makes it a difficult challenge) then the rest is handled by vscode.
• Second, if no symbol is available, the cursor jumps to the first regex match of the word. More advanced interactions, like cross-document support, variables with their correct scope... will need an entirely new parser, faster, compiled in native code, with error recovery and live update. If somebody with knowledge in ANTLR wants to step in, be my guest. If you want to look at the code, this will get you going: https://github.com/HAG87/vscode-maxscript-lsp/blob/d65b0dee3985850b2ab10aac6376d82345673647/server/src/mxsDefinitions.ts#L140