Peer to Peer: Module 2 Block 5 Day 2

[clintonjosephs]

Hello @HAMMAS-SALEEM 😄 ,

via Team Coco on GIPHY

Great job on your project! See below a few things I loved about it

• I love the way you structured the design
• The placement of the first, second and third positions looked stunning above the recent scores section
• Overall code structure
• No comments left in the deployed code
• No use of console.log
• Your code was easy to read and understand.

However, here are a few things you can add to make the project even better

• Form validation

  • I noticed users can add an exceeding number of characters in the scores textbox which can be detrimental to your design, consider adding a check for a maximum number of scores.
  • Consider checking the data inserted in the input for name collection, this will help protect data collected from malicious users and also improve data consistency (I noticed users can add space as name).

• DRY

  • I also noticed you used the END POINT in several places in your code. It would be nice to abstract the endpoint link in another file, export it and use the variable name in all places you might need it. This will help make your code more scalable should in case the endpoint URL changes in the future.

[jaflih]

Hello @HAMMAS-SALEEM ,

you did a very great work 🎊

I have only one suggestion to improve your project :

This code can be refactored to have a DRY project