Morning session : fourth week issue

HAMMAS-SALEEM / Portfolio

Portfolio Web App shows a sneak peek of what I have done in the programming field and what I can offer to someone who wants to hire me. It is built by HTML, CSS & Vanilla JavaScript

6 stars 1 forks source link

Morning session : fourth week issue #15

Open joskalenda opened 2 years ago

joskalenda commented 2 years ago

Hello Hammas, you did a great job, by the way, congratulation...! while scrolling our index file, I figure out that your 4spaces indentation is larger than expected, I think it could be a great idea to set it 2 spaces following coding best practices we saw earlier.

omarsalem7 commented 2 years ago

There is some margin in your screen with iPhone 5/se you can adjust that.

gtekle commented 2 years ago

I think it is good if you may stop the background scrolling effect when mobile nav drawer is opened. The CSS overflow property might help in that regard.