Weeks of 1/31/2024 & 2/7/2024

[glenncampagna]

Priorities:

• [moved] Water Availability Case Studies HARPgroup/HARParchive#1156
• [x] Sync Dataframe_Generator.R and Dataframe_Generator.Rmd (see Rob's PR), making the rmd the working version and getting rid of the original R script to avoid confusion
• HARPgroup/HARParchive#1153
• [moved] Caching NHD data to save time using memoise package HARPgroup/HARParchive#1163

Water Availability:

• [x] Re-export Smin metrics for all impoundments (at least runid_11) using om summary scripts and sudo HARPgroup/HARParchive#1159
  • [x] Document any resulting errors
  • [moved] Same for runid_13
• HARPgroup/om#525
  • This was encountered when re-exporting Smin with summarize_element.sh which calls waterSupplyModelNode.R
  • PR with proposed fix: https://github.com/HARPgroup/om/pull/523
  • [x] Create bug issue for this
  • [moved] Test including Carvins to make sure this is resolved
• [moved] Complete first draft for applicable sections of WA white paper (Smin, baseline, specific examples) HARPgroup/HARParchive#1149
• Storage needs to be summed by riverseg before joining with modeled metrics in WA workflow

WSP Summaries & DF Generator:

• [moved] Incorporate updated foundational data w/ gw_frac
• HARPgroup/HARParchive#1153
  • [x] Document example using run_sets in HARPgroup/HARParchive#1130
• [moved] Debug basemap function within mapgen HARPgroup/HARParchive#1133
  • [moved] Test w/ previously non-working origins and update HARPgroup/HARParchive#1130
  • [x] Add reproducible error example to bug issue
• [moved] Modularize mapping function https://github.com/HARPgroup/HARParchive/issues/1106#issuecomment-1749533265
  • We can define multiple functions within the same file for tidiness
• [x] Begin CU analysis -- read in consumptive_use_frac with om_vahydro_metric_grid
  • Example of where these vars are stored, within rivseg model scenarios http://deq1.bse.vt.edu/d.dh/om-model-info/5328150
  • Can be pulled with the DF generator by adding "consumptive_use_frac" to rivseg_metric list
• [x] Double-check om_vahydro_metric_grid() is used wherever possible
• [moved] Remove any hard-coding from table generation, they should automatically display whole dataframes
  • Will fix table 1 facil name column

Organization:

• [x] Update the ReadMe for the regional summary rmd including: workflow w/ df generator, params, localities available, regions available, example basins for major rivers (Ella)
• [x] Review weekly issues from the summer and make sure no tasks got left behind
• [x] Organize 2023 folder. Add folders for functions used in summaries, rmd & Df generator. Remove unused/outdated files (Meg)
  • [x] Update paths where functions are called

[gmahadwar]

@glenncampagna @megpritch @EllaF21 @rburghol Foundation dataset with gw_frac has been uploaded to include the groundwater fraction in tables. See the "...02-05.csv"

[glenncampagna]

Updates from 2/2 Water Availability meeting w/ @rburghol

2 key questions:

1. Where (in VAhydro) will we store the WA values/metrics?
2. When will the WA values/metrics be calculated and exported

Proposed answers:

1. WA metrics will be stored within a demand scenario for a riverseg model (ex. runid_11) and labeled with the scenario/runid which was used as the baseline scenario (ex. runid_0)
2. We should create a standalone routine for calculating and exporting WA metrics (after model post-processing routines ex. waterSupplyModelNode.R)
   • Note: all WA values will be relative to 2 scenarios/runids : the demand scenario and the baseline scenario (which won't always be runid_0)
   • Because multiple impoundments can be within one riverseg, storage needs to be summed by riverseg before joining with modeled metrics in our WA workflow

[gmahadwar]

@megpritch @EllaF21 @glenncampagna @rburghol I've pushed a branch (gm0208) that removes the outdated rgeos and ggsn, and removes instances that they are referenced. While it shouldn't conflict with anything you are working on, I wanted to get an "ok" from someone before completing the pull request. Thanks!

Tested on Big Sandy as in https://github.com/HARPgroup/HARParchive/issues/1130#issuecomment-1932834017 and it still runs. I've added a replacement scalebar using ggspatial, and while the font is currently too small it displays similarly to the one you had already developed using ggsn.

[glenncampagna]

@gmahadwar Multiple tests with different origins on your branch have run smoothly !

@glenncampagna Thanks, pull request merged now. -gmahadwar