Note @BrendanBrogan @gmahadwar -- there was a bug in this code that had eliminated all but the first 2 model data columns for facilities, so in other words, the code retrieved all of the data via om_vahydro_metric_grid for facilities, but then eliminated them from the data frame just prior to saving the csv file, so they were then unavailable to generate the final Rmd tables.
Note: there is another spot in the code that needs review, I will indicate in another remark and tag you all. Basically, it is eliminating any facility whose lat/lon is null, but as we had talked about early in the process, we need to be treating these with a "full join" between:
the om_vahydro_metric_grid() returned data which has all that was modeled, and is tagged by riverseg,
with the spatially contained data -- which might have facilities that were not modeled in 2019 because they were not in existence or were not populated with WSP data
Thus, with this full-join dataset we can see what was and wasn't simulated. DEQ is maintaining this portion of the code, so, this doesn't have to get completed by the end of the project, however, given that at least some of these may have null geometry values, we will want to insure that the final Rmd routine doesn't choke if given a point with null geometry.
Moreover, I think that it could be useful to have an appendix, or at least warning message text at the end of the routine to say "facility X with hydroid Y does not have a valid lat/lon".
Note @BrendanBrogan @gmahadwar -- there was a bug in this code that had eliminated all but the first 2 model data columns for facilities, so in other words, the code retrieved all of the data via
om_vahydro_metric_gridfor facilities, but then eliminated them from the data frame just prior to saving the csv file, so they were then unavailable to generate the final Rmd tables.Note: there is another spot in the code that needs review, I will indicate in another remark and tag you all. Basically, it is eliminating any facility whose lat/lon is null, but as we had talked about early in the process, we need to be treating these with a "full join" between:
om_vahydro_metric_grid()returned data which has all that was modeled, and is tagged by riverseg,Thus, with this full-join dataset we can see what was and wasn't simulated. DEQ is maintaining this portion of the code, so, this doesn't have to get completed by the end of the project, however, given that at least some of these may have null geometry values, we will want to insure that the final Rmd routine doesn't choke if given a point with null geometry.
Moreover, I think that it could be useful to have an appendix, or at least warning message text at the end of the routine to say "facility X with hydroid Y does not have a valid lat/lon".