Use Available Storage for Smin and Water Availability (not total Storage)

[glenncampagna]

Problem

• Total storage has been used so far for Smin calculations (Storage, local_impoundment_Storage, etc.)
• We need to be using available storage (use_remain_mg, etc. )

Column Names in Runfiles vary by object_class

• hydroImpoundment:

  • Total Storage col name: Storage
  • Usable Storage col name: use_remain_mg

• waterSupplyModelNode:

  • Total Storage col name: impoundment_Storage
  • Usable Storage col name: impoundment_use_remain_mg

• waterSupplyElement:

  • Total Storage col names: local_impoundment_Storage, impoundment_Storage, or Storage
  • Usable Storage col names: local_impoundment_use_remain_mg, impoundment_use_remain_mg

Units!

• The total storage columns previously used were assumed to be in units of acre-feet
• It looks like usable storage will always come in units of million gallons
• [x] The current conversion of ac-ft to mg will need to be removed in each script that is modified

Scripts that Need to be Updated: OM scripts are complete. See PR https://github.com/HARPgroup/om/pull/545

• [x] hydroImpoundment.R
• [x] waterSupplyModelNode.R
• [x] waterSupplyElement.R
• [ ] WaterAvailabilityCaseStudies.Rmd

[rburghol]

@glenncampagna thanks for putting these together, with the relevant column names!

[rburghol]

@glenncampagna I have now updated this for the three system automated routines that you outlines above (impoundments, watersheds and systems with onsite impoundments). Thanks again for spelling all of this out, and also, thanks for keeping the code in these functions clear and concise as they were very simple to update.