BigSandy_UpperTennessee_2

[gmahadwar]

Things to fix as seen by running BigSandy_UpperTennessee_2 We discussed some of these last time as being fixed by the config, which hasn't been updated, but pasting the entire list here to avoid further delay in creating an issue.

• [ ] climate change map & tables for L90/L30 should be after the regular L90/L30, not interspersed between them
• [ ] unmet demand table is mostly empty, can we filter to only those where there's unmet demand?
• [ ] remove empty sections like appendix at the end
• [ ] L90 and on Maps still showing in the legend and title. Legend not obvious what the mgy means
• [ ] L90 and rest of the tables don't have the human column names "runid_11_l90_Qout" etc.
• [ ] Table 1- Are hydroid showing as NA because they started reporting after the last model?
• [ ] do we need to explain why Table 1 rivseg id empty even if not just gw, and the gw_frac is NA instead of zero? (@gmahadwar ?)
• [ ] (@gmahadwar) Wytheville hatchery the 2040 model value updated since then, so wsp_2020_2040_mgy was from state plan time, we have to check which is better and potentially rerun the model. Potentially some other values have this same issue.
• [ ] @COBrogan Adding why majority of unmet demand table outputs are are NA instead of 0 (likely indicating no data in the df generator, not values of zero which are displayed)

[rburghol]

@gmahadwar @megpritch

• "climate change map & tables for L90/L30 should be after the regular L90/L30, not interspersed between them"
  • This should be handled in runset - or @gmahadwar arenyou sayibg this IS how it's defined in runset but Rmd is broken?
• Several of these seems to be how "Missing data" should be handled (unmet demand, etc). Firstly, there should be none with no data :), so if we have nulls/NAs l it means that we need to either rerun the model or re-run the summary scripts in the areas of interest. If model runs yield NA we should define default values for n/a and handle in dataframe generator.
• appendix appear/disappear should be in the runset, unless we have decided that there should not be an appendix.
• hydroid should never be null - this is likely a dataframe generator issue
• if rivseg is wmpty it's probably that the model entities "riverseg" propcode is null and should be fixed in model database. We should create an issue to list all instances so we can correct. Not part of Rmd I think.