Non-conforming cases of sub-watershed resegmentation

juliabruneau commented 1 year ago

Re-segmenting a tidal segment.

Subwatersheds in cbp6 segments that drain to tidal waters (ends with 0000) cannot get stream hydro parameters from the parent watershed because the tidal segments lack certain data. Example: ./run/resegment/add_sub_watershed.bat YL0_7010_0000_beaverdam YL0_7010_0000 cbp-6.0 subsheds 17.57 will fail at the end when using copy_parent.R. However, since a tidal segment HUC10 may still have non-tidal tributaries, we need to be able to simulate them.
Details:

Segments that end in 0000 have no river channel simulation.
- The land runoff/etc goes directly to estuary model
- No entries in input/param/river/[PARAMETERS]/ADCALC.csv, HYDR.csv and SCRORG.csv
There ARE entries in config/catalog/geo/[GEO]/rivernames.csv
There ARE entries in config/catalog/geo/[GEO]/land_water_area.csv
There ARE entries in input/scenario/river/land_use/land_use_2013VAHYDRO2018615.csv
- AND, the land use DOES get re-segmented when running add_sub_watershed.bat Manually copying HYDR/SCRORG and ADCALC
I split the 2nd half of add_sub_watershed.bat into another script copy_ad_hy_sc
- This script handles just those things that are in an existing riverine simulation.
- add_sub_watershed.bat calls copy_ad_hy_sc after doing the first part.
If add_sub_watershed.bat fails in the hydro parameters part, you can run copy_ad_hy_sc manually with a different downstream source to copy from, since the resegmentation has already been accomplished. Like so:
- ./run/resegment/copy_ad_hy_sc YL0_7012_7010 YL2_6580_0001 cbp-6.1 subsheds

Nested Re-Segmentation

Note: since these failed partway thru, needed to go in and delete,
Ex: JB0_7050_0001_cranstons_mill
- flows into JB0_7050_0000_yarmouth which flows into JB0_7050_0000
solution:
- re-segment JB0_7050_0000_yarmouth, then resegment JB0_7050_0001_cranstons_mill from the subwatershed that results.
- use Diascund Creek JB0_7052_0001 as the template for default stream parameters.
  - ./run/resegment/add_sub_watershed.bat JB0_7050_0000_yarmouth JB0_7050_0000 cbp-6.1 subsheds 10.11 JB0_7052_0001 blank
  - Note: returned JB0_7054_7050 for Yarmouth below Cranstons, and renamed, so need to use that in the next step.
  - ./run/resegment/add_sub_watershed.bat JB0_7050_0001_cranstons_mill JB0_7054_7050 cbp-6.1 subsheds 6.99

Other

These were not created for whatever reason, or at least, they were not on a list.

[ ] JU3_6950_7330_falling_springs ows-watershed-dash-info/421054
- See: https://github.com/HARPgroup/vahydro/issues/793
[ ] Harris Creek: JL6_7440_7430_harris_creek / ows-watershed-dash-info/67865
- has non-conforming everything, watershed container has no channel, only the facility model as a child that contains an impoundment
- Used a manual mode for ftable.R instead of reconfiguring to have a local channel and impoundment, with facility model as source of demands and releases etc.
- complete: om-model-info/7048152
[ ] Beaver Creek: JL1_6562_6560 / ows-watershed-dash-info/68123
- This may be fine but was done in 6.0 and needs to be re-done now

rburghol commented 1 year ago

Details:

Segments that end in 0000 have no river channel simulation.
- The land runoff/etc goes directly to estuary model
There ARE entries in config/catalog/geo/[GEO]/rivernames.csv
There ARE entries in config/catalog/geo/[GEO]/land_water_area.csv
There ARE entries in input/scenario/river/land_use/land_use_2013VAHYDRO2018615.csv
- AND, the land use DOES get re-segmented when running add_sub_watershed.bat
Fails at copy_parent.R as noted above, but:
- Parent (YL0_7010_0000) does have input/param/transport/wF180615RXAPXXXW_l2w.csv
- Parent (YL0_7010_0000) does have input/param/transport/wF180615RXAPXXXW_s2r.csv
- does NOT have SCRORG, HYDR, ADCALC
Ways to resolve: yes, "Duplicating information from another YL -file?"

rburghol commented 1 year ago

Little Creek Reservoir

./run/resegment/add_sub_watershed.bat vahydrosw_wshed_JB0_7050_0000_little_creek JB0_7050_0000 cbp-6.1 subsheds 5.098 JB0_7052_0001 blank
riverseg=JB0_7056_7050
 Rscript run/resegment/ftable_creation.R $riverseg local_channel vahydro-1.0 "/opt/model/p6/vadeq/input/param/river/vahydro_2022/ftables/"
/opt/model/meta_model/run_model hsp2_cbp6 $scenario $riverseg tmp/scratch/rwb river prep 01_run_rug

rburghol commented 1 year ago

Note: Harris creek is a direct + pump store, where they pump from James to Graham Creek reservoir (reservoir DA 5.98), then use that to supplement the intake on Harris Creek (29.9 sqmi), so the subwatershed is 29.9 - later we will add a custom subshed in ops model.

Rscript run/resegment/subsheds_naming.R JL6_7440_7430_harris_creek /opt/model/p6/vadeq/config/catalog/geo/vahydro/rivernames.csv cbp-6.1 JL6_7440_7430
Rename feature hydrocode to: vahydrosw_wshed_JL6_7441_7440
Rscript run/resegment/ftable_creation.R JL6_7441_7440 manual vahydro-1.0 /opt/model/p6/vadeq/input/param/river/vahydro_2022/ftables/ 29.9 11372 2 0.00120395
./run/resegment/add_sub_watershed.bat JL6_7441_7440 JL6_7440_7430 cbp-6.1 subsheds 29.9 JB0_7052_0001 blank

Then run

i=JL6_7441_7440
scenario=subsheds
/opt/model/meta_model/run_model hsp2_cbp6 $scenario $i auto river 
i=JL6_7440_7430 
/opt/model/meta_model/run_model hsp2_cbp6 $scenario $i auto river

rburghol commented 1 year ago

Ivy Creek ows-watershed-dash-info/68185

./run/resegment/add_sub_watershed.bat JL2_6441_6520_ivy_creek JL2_6441_6520 cbp-6.1 subsheds 29.75 
# renamed the vahydro feature etc/
Rscript run/resegment/ftable_creation.R JL2_6442_6441 local_channel vahydro-1.0 "/opt/model/p6/vadeq/input/param/river/vahydro_2022/ftables/"

Rocky Pen ows-watershed-dash-info/68056

Resegment:

./run/resegment/add_sub_watershed.bat RU5_6030_0001_rpr RU5_6030_0001 cbp-6.1 subsheds 5.21
# renamed the vahydro feature etc/

Use R/nhd to get channel info:

nhd_out<-get_nhdplus(comid="8476018") # comid for the nhd+ segment below rocky pen before Rapp
nhd_out$totdasqkm / 2.58999
# 5.358322
m_cat <- plot_nhdplus(list(nhd_out$comid))
nhd <- get_nhdplus(m_cat$basin)
trib_comids = get_UT(nhd, comid, distance = NULL)
nhd_df <- as.data.frame(st_drop_geometry(nhd))
length_ft = as.numeric(sqldf(paste("select sum(lengthkm) from nhd_df where streamorde =",nhd_out$streamorde ))) * 3280.84
# 11453.41

add the ftable with custom args since model did not have a channel
- Rscript run/resegment/ftable_creation.R RU5_6031_6030 manual vahydro-1.0 "/opt/model/p6/vadeq/input/param/river/vahydro_2022/ftables/" 5.358322 11453.41 3 0.01054565

Motts Run

Get outlet from vahydro intake: ows-vwuds-intake-info/63027
- -77.543333333333, 38.312222222222
Run new script to print props: https://github.com/HARPgroup/vahydro/blob/master/R/modeling/nhd/nhd_channel_model_props.R
- length_ft, da_sqmi, cslope 28152.88804 10.4285730832938 0.00720692184836031
subdivide: ./run/resegment/add_sub_watershed.bat RU5_6030_0001_motts_run RU5_6030_0001 cbp-6.1 subsheds 10.4285730832938
Rename seg id to RU5_6032_6030
make ftable: Rscript run/resegment/ftable_creation.R RU5_6032_6030 manual vahydro-1.0 "/opt/model/p6/vadeq/input/param/river/vahydro_2022/ftables/" 10.4285730832938 28152.88804 3 0.00720692184836031

Hunting Run

Lat: 38.351666666700 Longitude: -77.639166666700
length_ft, da_sqmi, cslope 18428.47828 7.13678431190854 0.0067694728358619
./run/resegment/add_sub_watershed.bat RU5_6030_0001_hunting_run RU5_6030_0001 cbp-6.1 subsheds 7.13678431190854
RU5_6033_6030
Rscript run/resegment/ftable_creation.R RU5_6033_6030 manual vahydro-1.0 "/opt/model/p6/vadeq/input/param/river/vahydro_2022/ftables/" 7.13678431190854 18428.47828 3 0.0067694728358619

rburghol commented 1 year ago

Mattaponi, Lower York

./run/resegment/add_sub_watershed.bat YL0_6930_0000_richardsons_mill YL0_6930_0000 cbp-6.32 subsheds YL2_6580_0001 blank
See subwaterdshed update for Ware Creek here: https://github.com/HARPgroup/vahydro/issues/804
Update hydrocode
length_ft, da_sqmi, cslope 1745.40688 6.3173989088761 0.00001
Rscript run/resegment/ftable_creation.R YL0_6934_6930 manual vahydro-1.0 "/opt/model/p6/vadeq/input/param/river/vahydro_2022/ftables/" 6.317 1745.40688 4 0.00001

HARPgroup / HARParchive