Week of 1/30/2023 & 2/6/2023

[juliabruneau]

This work was started this week and it will continue next week. After we have successfully finished with our finalization, we can switch the focus to the new analytical work.

Finalizing previous work:

• [x] elfgen_huc() in summary script https://github.com/HARPgroup/HARParchive/issues/556
  • [x] Need to ask Rob & Joey about this!
  • [x] Joey investigated: https://github.com/HARPgroup/HARParchive/issues/556#issuecomment-1428546522
• [x] Final testing on add_sub_watershed.bat https://github.com/HARPgroup/cbp_wsm/issues/85
  • [x] Perform testing on 3 diff scenarios (+fgrep) and report about it
• [x] Manually implement changes to the meta model
  • [x] Test the new version of meta model with empty link directory (with those functions happening in river/run)
  • [x] Flow chart info session (between analysts), Monday 2/6
• [x] Updating master list of Scripts and their Uses: https://github.com/HARPgroup/HARParchive/issues/505
  • [x] Add the meta-model flow to this issue as well

Coming up:

• [x] Schedule a meeting with @jdkleiner about starting the QA, reference: https://github.com/HARPgroup/HARParchive/issues/736

[glenncampagna]

Weekly Progress

• Re-organized and tested the meta_model pull request for demand/wd/ps processing to account for Rob's changes in river/run, the next step will be manually implementing them into the main branch
• The summary routine with both summarize_values.R and summarize_figures.R can now be added to hsp2_cbp6/river/analyze/04_analysis and hspf_cbp6/river/analyze -- once we test elfgen_huc(). #742
• Analyst check-in about Glenn's meta-model flowchart and recent changes
• Testing has been performed with add_sub_watershed.bat, and the results have been put in the issue linked above.
  • Proportioning is performing as it should - regardless of changing the drainage area
  • Testing was done on the Norther River test case: RU4_5640_6030_lake_pelham as well
  • An error occurs still with some cases, like: OR3_7740_8271_tinker:

    Error in `[<-.data.frame`(`*tmp*`, 1, value = "OR3_7743_7740") : 
    replacement has 1 row, data has 0 
    Calls: [<- -> [<-.data.frame 

• The updated summary of all scripts and their arguments (from fall 2022 and winter 2023), have been put in the summary issue.
  • Now called: https://github.com/HARPgroup/HARParchive/issues/505

[glenncampagna]

Meta-model flowchart of demand/wd/ps processing

[jdkleiner]

Excellent! Love the flowchart. I'm looking forward to these items getting wrapped, and then we can move into generating analytics in R Markdown.