Review Summary

[rburghol]

• mapping_codereview.Rmd: in 2023-2024 project https://github.com/HARPgroup/HARParchive/blob/master/HARP-2023-Summer/mapping_codeReview.Rmd
• JL7_7070_0001
• ran by changing params in header, but should be able to run from command prompt OK (will verify)
• Did not test BBOX, but saw that bbox_type = "vahydro" is supported in command line params.
• Test:

  
  rmarkdown::render(
  'C:/usr/local/home/git/HARParchive/HARP-2023-Summer/mapping_codeReview.Rmd',
  output_file ='C:/Workspace/tmp/james_rva_wsp.Rmd',
  params = list(
      rivseg = "JL7_7070_0001", locality = "NA", region = "Shenandoah_2",
      type = "facility", model_version = "vahydro-1.0", runid_list = c("runid_400", "runid_600"), 
      metric= "wd_mgd",table_limit = "boundary",
      map_type = "basin", bbox_type = "auto"
  )
  )

rmarkdown::render("~/Desktop/GitHub/HARParchive/HARP-2023-Summer/mapping_codeReview.Rmd", output_file = "~/Desktop/HARPteam23/mappingRMD_knit", params = list( rivseg = "JL6_7430_7320", locality = "Culpeper", region = "Chowan_2", type = "facility", model_version = "vahydro-1.0", runid_list = c("runid_11","runid_13"), metric = "fiveyr_avg_mgy", map_type = "locality", table_limit = "boundary", bbox_type = "auto"))

[rburghol]

Hey all -- happy to report that I used the runid_11/runid_13 arguments in my test rendering and the map and table rendered well. Couple things (will update in the body of this issue):

• The table should be rendered as a table, not as an image, as users will invariable wish to copy items from these.
• Stream order and/or threshold for displaying should be part of the customizable styling parameters -- When I do the whole James, it gets too busy (see below).
• It's time to start retrieving custom items from vahydro.