search

HARPgroup / cbp6

Chesapeake Bay Program Phase 6 Model Suite
0 stars 0 forks source link

Added scenario labeling in fig1.hydrograph #153

Closed rburghol closed 4 years ago

rburghol commented 4 years ago

Daniel - please review this pull request. I added the ability to customize the labels in fig1.hydrograph routine as a trial to be used in all others. I am not super familiar with ggplot so I was a little unsure of how the label appeared (to my eye) to be passed in with the attribute "color" in the aes() command. BUt it works, or seems to. Please let me know if this seems sound and I will push it into some other graphics and tables. I would like to have a quick visual cue as to what we are seeing in each table so that they stand alone as opposed to needing to review a preamble that tells you "scenario 1 is USGS and scenario 2 is the vahydro model" or something.

I changed: geom_line(aes(y=Scenario2, color="VAHydro Scen. 1") To: aes(y=Scenario1, color=cn1)

Where I passed in cn1 (and cn2) to the function with defaults already set: fig1.hydrograph <- function(all_data, cn1='Scenario1', cn2='Scenario2') {

rburghol commented 4 years ago

Awesome -- I will go ahead and merge this change, and make a few others for tables that I am working on right now. I figure the mean flows, low flows, and hydrographs will take us quite far.