HARPgroup / cbp6

Chesapeake Bay Program Phase 6 Model Suite
0 stars 0 forks source link

duplicate functions must go! 7q10 has 3 extra instances (one of them erroneous) #203

Open rburghol opened 4 years ago

rburghol commented 4 years ago

The one true 7q10 function is hydro_tools/LowFlow/fn_iha_7q10 -- all others must go.

2 extras are in this cbp6 module in:

Also, there was a replication of the 7q10 code in the om module R/summarize/waterSupplyModelNode.R, that was erroneous since it did not screen for instances where only one 7 day flow record is present (from a short model run) -- thus, it fails and kills the script. That has been replaced. Henceforth we need to make sure that all config.R scripts need to reference the following to load 7q10 and alf) functions:

source(paste(hydro_tools,"LowFlow/fn_iha.R", sep = "/"));  

This will likely break some code, but that's OK, we need to make this happen. And, in the coming year we will transform hydro-tools into a proper library!