I have a pump store reservoir that I am testing, but Smin is resolving as zero, even when there is a bunch of storage (or a little bit of storage) remaining. It appears that the code is skipping calculation of Smin if it IS marked as pump_store == TRUE, when it should be calculating it.
if (pump_store || !imp_enabled) {
flow_ts <- ddat2$Qintake
flow_ts_name = "Source Stream"
# No storage if there is no impoundment
Smin_L30_mg <- 0
Smin_L90_mg <- 0
}
The above code sets Smin to 0.0 if this is a pump_store, but if it's a pump store it DOES have storage by definition, and it's storage needs to be counted. Now, I believe that we can amend this by saying either if (!pump_store || !imp_enabled)
I have a pump store reservoir that I am testing, but Smin is resolving as zero, even when there is a bunch of storage (or a little bit of storage) remaining. It appears that the code is skipping calculation of Smin if it IS marked as
pump_store == TRUE, when it should be calculating it.sudo -u www-data ./modules/om/sh/summarize_element.sh 323521 401pid = 4824696; elid = 323521; runid = 401I think the problem is here:
The above code sets Smin to 0.0 if this is a pump_store, but if it's a pump store it DOES have storage by definition, and it's storage needs to be counted. Now, I believe that we can amend this by saying either
if (!pump_store || !imp_enabled)See amended code in PR #522