search

HASwitchPlate / openHASP-custom-component

Home Assistant custom component for openHASP
https://www.openhasp.com
MIT License
51 stars 12 forks source link

PIL uses a width,height tuple for resize() and thumbnail(). #121

Closed FreeBear-nc closed 4 months ago

FreeBear-nc commented 5 months ago

Using a 300x480 img object, and surprised to find the image was being resized to 480x300 with fitscreen=true. Looking at the image_to_rgb565 routine in the openHASP custom component, height & width had been transposed.

dgomes commented 5 months ago

Interesting catch... how this went by for so long

FreeBear-nc commented 5 months ago

If you only ever used a 1:1 aspect ratio, it would never be noticed.

fvanroie commented 5 months ago

fitscreen is relatively new and not extensively documented/used I guess...

fvanroie commented 4 months ago

I made a 0.7.3 pre-release and also set 0.7.2 as latest version.

@FreeBear-nc Please test 0.7.3 and if all is well, that will be the latest release, sometime next week.

FreeBear-nc commented 4 months ago

Appears to be functioning as expected.