HASwitchPlate / openHASP

HomeAutomation Switchplate based on lvgl for ESP32
https://www.openhasp.com
MIT License
726 stars 185 forks source link

ACE 1.35.4 on CDNJS missing themes #783

Closed corbolais closed 2 months ago

corbolais commented 2 months ago

Perform all steps below and tick them with [x]

Describe the bug

Compiling latest openHASP (as of yesterday) includes ACE editor in version 1.35.4 which is loaded from CDNJS as well as corresponding themes. ace.min.js v1.35.4 is loaded, whereas themes for v1.35.4 are 404s.

To Reproduce

Working: https://cdnjs.cloudflare.com/ajax/libs/ace/1.34.0/theme-monokai.js

Failing with 404: https://cdnjs.cloudflare.com/ajax/libs/ace/1.35.4/theme-monokai.js

Expected behavior

Accessible theme file: https://cdnjs.cloudflare.com/ajax/libs/ace/1.35.4/theme-monokai.js

corbolais commented 2 months ago

Actually, v1.35.3 themes are accessible: https://cdnjs.cloudflare.com/ajax/libs/ace/1.35.3/theme-monokai.js

fvanroie commented 2 months ago

It seems the CDN wasn't updated properly with all themes.