HBClab / NiBetaSeries

Nipype implementation of BetaSeries Correlations (Beta)

https://nibetaseries.readthedocs.io

MIT License

32 stars 28 forks source link

[FIX, DOC] Rename low-pass filter to high-pass filter #198

Closed tsalo closed 5 years ago

tsalo commented 5 years ago

Summary

Fixes #130. Fixes #196.

List of changes proposed in this PR (pull-request)

Replace all uses of "low pass filter" with "high pass filter" in code and documentation.
Fix a couple of typos in docs/workflows.rst.
Add @tsalo to Zenodo file.

codecov[bot] commented 5 years ago

Codecov Report

Merging #198 into master will decrease coverage by 5.13%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
- Coverage   86.31%   81.17%   -5.14%     
==========================================
  Files          11       11              
  Lines         358      356       -2     
  Branches       40       39       -1     
==========================================
- Hits          309      289      -20     
- Misses         29       55      +26     
+ Partials       20       12       -8

tsalo commented 5 years ago

I'm not sure why CodeCov is registering as failing. Maybe because coverage is decreasing?

jdkent commented 5 years ago

@tsalo, if #200 looks good to you, I can merge that in hopefully that will help fix the codecov error you are getting.

I broadened the range of acceptable coverage from 70-100 to 60-100
I ignored certain files (_version.py) and the test files.

tsalo commented 5 years ago

@jdkent For some reason CodeCov is passing now, but I'm happy to wait for #200 and then update from master.