search

HBIDamian / MOTDShuffle

PMMP Plugin: MOTDShuffle - Gives a random MOTD shuffle, such as the Minecraft Featured Servers! :D
Apache License 2.0
7 stars 6 forks source link

Updated to API 4.0.0 #11

Closed Vecnavium closed 2 years ago

Vecnavium commented 2 years ago

This PR adds the functionality to function on API 4.0.0.

This has been tested and works as expected with no errors and MOTD shows up.

Vecnavium commented 2 years ago

You can create a separate branch for API 4.0.0 if you wish up to you since I can't do it.

Vecnavium commented 2 years ago

I guess doing v2.0.0 is reasonable since it's a complete different API, if you think otherwise and want a specific version number let me know and I will revert or modify to your liking.

HBIDamian commented 2 years ago

I would prefer if the versioning could follow https://semver.org/. The updates you provided aren't exactly considered gamebreaking. I may be drunk as fuck by the time of replying to you, but I still see that it isn't really a "major change". I'd be happy for it to be a minor or patch change though.