Open jdranczewski opened 2 months ago
Ah, the different behaviour under Python and IPython is because on my machine Python correctly raises the RecursionError
, which gets caught by the try ... except
block in _load
, but in IPython the recursion Exception is not raised correctly and the process crashes. This seems to be an issue in IPython: https://github.com/ipython/ipython/issues/12197
So it's both a problem of the recursion happening and IPython handling it badly.
When the imported file calling
config
is for example on the D: drive, the recurrent function that searches its parent folders will eventually reach D:/. Unfortunately, the check that's meant to stop the recursion considers the drive of the working directory (say, C:/) to be the top folder in some circumstances. The offending lines are these: https://github.com/HBNetwork/python-decouple/blob/0573e6f96637f08fb4cb85e0552f0622d36827d4/decouple.py#L220-L223This results in a silent crash of whatever code is running, but only when the working directory is on a drive different than the drive where the file using
config
is, I think? It also only happens in IPython, which may be handling working directories differently. This made it quite amusing to diagnose (I was using a different library that importsdecouple
), and I presume it may make it difficult to reproduce easily.I suggest replacing the check with:
which will catch if the parent is the same as the current path more explicitly.