HBO-i / ictresearchmethods.nl

The ICT Research Methods is a set with research methods for design-oriented research within ICT
https://ictresearchmethods.nl
Creative Commons Zero v1.0 Universal
9 stars 12 forks source link

Feature/183/alert component #185

Closed NoWarries closed 1 year ago

NoWarries commented 1 year ago

Description

Closes #183

Added a concept Alert component for usage in for example the issue described in #183

Screenshot 2023-10-20 at 15-25-25 ICT Research Methods — Methods Pack for Research in ICT

Has several configuration options, easily scalable

Screenshot 2023-10-20 at 14-40-47 ICT Research Methods — Methods Pack for Research in ICT

Works alright on darkmode. Readable

Screenshot 2023-10-20 at 15-35-52 ICT Research Methods — Methods Pack for Research in ICT

Type of change

Please select the option that is relevant

Checklist

Additional information

Considerations

Placement

Not sure if this is the right place to put the alert box. Should it be added to more pages? Do we still need a sidenav item to resolve #183 #184

Do we even need this with the sidenav implemented?

Icons

I am not sure what icons are used (which libary). Thus I cannot add icons appropiate for the Alert. e.g. a checkmark on a success message. All use information icon for now

netlify[bot] commented 1 year ago

Deploy Preview for stellular-banoffee-031bf4 ready!

Name Link
Latest commit e78e152bc74f00b029ed407372d506f553ce35e8
Latest deploy log https://app.netlify.com/sites/stellular-banoffee-031bf4/deploys/65339bf7dbcf3a0007ee4065
Deploy Preview https://deploy-preview-185--stellular-banoffee-031bf4.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 year ago

Deploy Preview for test-ictresearchmethods ready!

Name Link
Latest commit e78e152bc74f00b029ed407372d506f553ce35e8
Latest deploy log https://app.netlify.com/sites/test-ictresearchmethods/deploys/65339bf78aeac10008c316a8
Deploy Preview https://deploy-preview-185--test-ictresearchmethods.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jochemvogel commented 1 year ago

Thanks. Personally I don't agree with the prominent place the alert gets. I did it more subtle here (https://deploy-preview-184--stellular-banoffee-031bf4.netlify.app/)

I do think we can use this alert boxes on other routes:

  1. https://ictresearchmethods.nl/research-pattern-navigator/
  2. https://ictresearchmethods.nl/methods-overview/

Going to create a new version of the methods overview next week, so an alert, that the content might be more clear on the old site, might work for now.

Could you implement the info/blue one on top of those two pages. That will definitely help the user.

Thanks!

NoWarries commented 1 year ago

Thanks. Personally I don't agree with the prominent place the alert gets. I did it more subtle here (https://deploy-preview-184--stellular-banoffee-031bf4.netlify.app/)

I do think we can use this alert boxes on other routes:

1. https://ictresearchmethods.nl/research-pattern-navigator/

2. https://ictresearchmethods.nl/methods-overview/

Going to create a new version of the methods overview next week, so an alert, that the content might be more clear on the old site, might work for now.

Could you implement the info/blue one on top of those two pages. That will definitely help the user.

Thanks!

Honestly agree.

Will revert changes on the homepage so the component is isolated in the branch. Otherwise feel free to cherypick if deemed component could be useful

jochemvogel commented 1 year ago

Perfect! I've merged the other one. The additions on this MR might be very helpful for the users that prefer the old one.

Not planning to keep the wiki all the time, but collecting feedback from the users is very helpful to eventually remove the whole wiki.

jochemvogel commented 1 year ago

@NoWarries I was wrong. It's pretty nice to have those alert boxes on the main page. I added those and will merge it. You can adjust things if you want, but it's comparable with your initial design.