Closed ppodhajski closed 7 years ago
This does not look right, esp. the fact that it makes an exception for localhost!?
I guess this is for the Tide screen lock - why not layer it there?
Correct, it is for the Tide screen lock and I had the same reaction as you initially.
The http server in Tide could extend the ZeroEQ one, implementing the 403 in a generic way for the restricted use case needed?
theoretically yes but not clear how to do it. Would need to add a protected virtual function for that specific purpose - right now_processRequest() is well hidden in the pimpl to which derived classes have no access.
Will be implemented by an http::Server subclass in Tide
Missing unit test. Then you will have to find a better solution for the 'localhost' problem. Maybe a whitelist to block() or similar. Otherwise this is OK.