Fix for gcc-7 warning in jsoncpp.cpp.

HBPVIS / ZeroEQ

Cross-platform C++ library for fast binary and REST messaging

https://hbpvis.github.io/

Other

41 stars 25 forks source link

Fix for gcc-7 warning in jsoncpp.cpp. #239

Closed ptoharia closed 6 years ago

bbpbuildbot commented 6 years ago

Can one of the admins verify this patch?

rdumusc commented 6 years ago

test this please

rdumusc commented 6 years ago

Thanks for the patch, but I think it's incorrect because it changes the behavior of the code... Since jsoncpp is an external dependency that's bundled in, the best way to fix it would be to either:

try to grab a more recent copy of jsoncpp from https://github.com/open-source-parsers/jsoncpp that has hopefully been fixed for gcc7
or disable the -Wimplicit-fallthrough using a CMake compile flag that only applies to this specific file

ptoharia commented 6 years ago

Ok, thanks @rdumusc !