HBehrens / puncover

Analyses C/C++ build output for code size, static variables, and stack usage
MIT License
431 stars 94 forks source link

Puncover will now unmangle cpp symbol names #4

Closed sarfata closed 7 years ago

sarfata commented 7 years ago

This requires an external tool (c++filt) which is called every time the elf is reparsed with the list of all the symbols.

It is enabled all the time because it knows to not change C symbols.

This PR closes #3.

Before: screenshot from 2017-03-19 09 43 58

After: screenshot from 2017-03-19 09 42 00

codecov-io commented 7 years ago

Codecov Report

Merging #4 into master will decrease coverage by 1.19%. The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #4     +/-   ##
=========================================
- Coverage   69.07%   67.87%   -1.2%     
=========================================
  Files          12       12             
  Lines        1051     1074     +23     
=========================================
+ Hits          726      729      +3     
- Misses        325      345     +20
Impacted Files Coverage Δ
puncover/puncover.py 0% <0%> (ø) :arrow_up:
puncover/collector.py 70% <15.78%> (-1.05%) :arrow_down:
puncover/renderers.py 35.19% <7.14%> (-1.71%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7896368...7673a3c. Read the comment docs.

HBehrens commented 7 years ago

Regarding my comment about lazy-initialization: I didn't realize that you are calling c++filt only once with the entire list. Maybe that's not so much of a bottleneck and initializing this lazily is not worth it all.

sarfata commented 7 years ago

I think I have addressed all your comments. Let me know what you think.