HBehrens / puncover

Analyses C/C++ build output for code size, static variables, and stack usage
MIT License
431 stars 94 forks source link

Pathlib port (Windows/Linux/MacOS) #70

Closed vChavezB closed 1 year ago

vChavezB commented 1 year ago

Based on the comments from @noahp I have rebased my last pull request to veriify that unit tests pass for different versions with github actions and python module tox.

Changes

Fixed

vChavezB commented 1 year ago

I did a local pull request on my fork and it fails for windows with python 3.6,3.7 and 3.9

https://github.com/vChavezB/puncover/actions/runs/3745394220/jobs/6359786909

I will have a look on this...

vChavezB commented 1 year ago

Ok I think the pipeline should now pass :)

codecov[bot] commented 1 year ago

Codecov Report

Base: 81.75% // Head: 81.57% // Decreases project coverage by -0.18% :warning:

Coverage data is based on head (d8bc167) compared to base (6f53a5f). Patch coverage: 79.24% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #70 +/- ## ========================================== - Coverage 81.75% 81.57% -0.19% ========================================== Files 11 11 Lines 1239 1297 +58 ========================================== + Hits 1013 1058 +45 - Misses 226 239 +13 ``` | [Impacted Files](https://codecov.io/gh/HBehrens/puncover/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Heiko+Behrens) | Coverage Δ | | |---|---|---| | [puncover/gcc\_tools.py](https://codecov.io/gh/HBehrens/puncover/pull/70/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Heiko+Behrens#diff-cHVuY292ZXIvZ2NjX3Rvb2xzLnB5) | `63.33% <0.00%> (-4.53%)` | :arrow_down: | | [puncover/renderers.py](https://codecov.io/gh/HBehrens/puncover/pull/70/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Heiko+Behrens#diff-cHVuY292ZXIvcmVuZGVyZXJzLnB5) | `54.21% <33.33%> (-0.04%)` | :arrow_down: | | [puncover/collector.py](https://codecov.io/gh/HBehrens/puncover/pull/70/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Heiko+Behrens#diff-cHVuY292ZXIvY29sbGVjdG9yLnB5) | `74.32% <65.95%> (-0.44%)` | :arrow_down: | | [tests/test\_collector.py](https://codecov.io/gh/HBehrens/puncover/pull/70/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Heiko+Behrens#diff-dGVzdHMvdGVzdF9jb2xsZWN0b3IucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Heiko+Behrens). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Heiko+Behrens)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

noahp commented 1 year ago

You can ignore that codecov check error by the way! I'll take a look at this patch soon. Looks solid though if it's passing all the tests on our 18 (!) supported configurations, amazing work!

noahp commented 1 year ago

Love it, thank you so much! merging now