Closed vChavezB closed 1 year ago
I did a local pull request on my fork and it fails for windows with python 3.6,3.7 and 3.9
https://github.com/vChavezB/puncover/actions/runs/3745394220/jobs/6359786909
I will have a look on this...
Ok I think the pipeline should now pass :)
Base: 81.75% // Head: 81.57% // Decreases project coverage by -0.18%
:warning:
Coverage data is based on head (
d8bc167
) compared to base (6f53a5f
). Patch coverage: 79.24% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
You can ignore that codecov check error by the way! I'll take a look at this patch soon. Looks solid though if it's passing all the tests on our 18 (!) supported configurations, amazing work!
Love it, thank you so much! merging now
Based on the comments from @noahp I have rebased my last pull request to veriify that unit tests pass for different versions with github actions and python module tox.
Changes
Fixed