search

HBehrens / puncover

Analyses C/C++ build output for code size, static variables, and stack usage
MIT License
431 stars 94 forks source link

Feature/support windows #74

Closed JPHutchins closed 1 year ago

JPHutchins commented 1 year ago

This tool looks great! Windows seems to work with a minimal change (adding .exe to the GCC tools and using platform agnostic path separator) but it made sense to have the unit tests pass for Windows and reenable the CI.

I'm not sure that the tool is fully Windows-compatible as-is. For example, under object names I only see entries in the code column. Stack column seems to be working for functions.

I'll run it on a Linux VM when I have a chance to see what it's supposed to look like - but I think a non-invasive change with regression testing is a good first step.

JPHutchins commented 1 year ago

Workflow passes: https://github.com/JPHutchins/puncover/pull/1

noahp commented 1 year ago

I'm so sorry, I've been very slow to respond recently! Thanks so much for this patch- I think this should be addressed by #70 , I'll close this PR for now, but definitely let me know if it's not working for you.