search

HBiSoft / HBRecorder

Lightweight screen recording Android library
MIT License
402 stars 137 forks source link

SDK 34 #154

Closed Dhina17 closed 6 months ago

HBiSoft commented 8 months ago

Thank you for the pull request. I will have a look and test it later today.

jerinjohnk commented 7 months ago

After upgrading our targetSdkVersion to 34, HBRecorder has started crashing on Android 14.

156 #157

robrechtme commented 7 months ago

Looks good to me, would be nice if this can get merged 🙂

eliaslecomte commented 6 months ago

Nice contribution @Dhina17!

I wonder if this is really how Android 14 intended us to use? What is the underlaying platform change that requires this? Could you link to the documentation?

Handler handler = new Handler(Looper.getMainLooper());
        mMediaProjection.registerCallback(new MediaProjection.Callback() {
            // Nothing
            // We don't use it but register it to avoid runtime error from SDK 34+.
        }, handler);
mirjalal commented 6 months ago

@HBiSoft when do you plan to merge these changes?

HBiSoft commented 6 months ago

@mirjalal Merged and is available in 3.0.2