HBiSoft / HBRecorder

Lightweight screen recording Android library
MIT License
423 stars 141 forks source link

Permission error #91

Closed Shah-Aayush closed 3 years ago

Shah-Aayush commented 3 years ago

Describe the bug Cannot start recording

Log shows toast :No permission for android.permission.WRITE_EXTERNAL_STORAGE on pressing start button.

Can it be reproduced in demo app installed this apk on physical device got error.

HBRecorder version 2.0.1

Device information

Screenshot
tempss
HBiSoft commented 3 years ago

That's strange.. Didn't it ask you for permissions?

Shah-Aayush commented 3 years ago

That's strange.. Didn't it ask you for permissions?

No It just asked me for microphone permission!

HBiSoft commented 3 years ago

I will have a look into it tomorrow.

In the meantime, please try the previous release, just to make sure I didn't mess something up with the previous release.

Shah-Aayush commented 3 years ago

I will have a look into it tomorrow.

In the meantime, please try the previous release, just to make sure I didn't mess something up with the previous release.

Same error persits

HBiSoft commented 3 years ago

I tested on a device (Samsung Galaxy S9) running Android 10 and I was not able to reproduce this issue.

Please go to "App info" and check if there is "Storage" permission. It should be there but unselected?

Shah-Aayush commented 3 years ago

I was only requested for mic permission. There was no storage permission requested ! In the settings, and in permission tab, there was only mic permission available.

ShizaS commented 3 years ago

im facing the exact same issue in Xiaomi 9T running android 10.

HBiSoft commented 3 years ago

I found the issue. I will update the library in the next 30 minutes.

HBiSoft commented 3 years ago

This should be fixed in 2.0.2 - https://github.com/HBiSoft/HBRecorder/releases/tag/2.0.2

Please test it and close the issue if it's fixed.

Thank you for reporting this.

ShizaS commented 3 years ago

Yes, its working now. Thank a lot for the quick response and fix. Really appreciate it.

ShizaS commented 3 years ago

I was just wondering if it's possible to record only the app screen excluding the status bar or any notification that pops up during the recording.

HBiSoft commented 3 years ago

@ShizaS See #22.

I assume this issue is fixed. Closing.