Remove broken `MLLP.Receiver.start/0`

HCA-Healthcare / elixir-mllp

An Elixir library for transporting HL7 messages via MLLP (Minimal Lower Layer Protocol)

Apache License 2.0

41 stars 19 forks source link

Remove broken `MLLP.Receiver.start/0` #25

Closed bryanhunter closed 2 years ago

bryanhunter commented 2 years ago

At one point MLLP.Receiver.start/0 could be called, and it would use the DefaultDispatcher. Currently, it only returns an error.

iex> MLLP.Receiver.start()                                           
** (ArgumentError) No tcp port provided
    (elixir_mllp 0.5.0) lib/mllp/receiver.ex:168: MLLP.Receiver.to_args/1
    (elixir_mllp 0.5.0) lib/mllp/receiver.ex:64: MLLP.Receiver.start/1

vikas15bhardwaj commented 2 years ago

Port and dispatcher are required fields now, otherwise, it will raise error. Any idea, in which case we need to start without dispatcher.

starbelly commented 2 years ago

@vikas15bhardwaj The issue is that we have start(opts \\ []) which definesstart/0 which will of course result in an error. We simply need to make opts mandatory. I'll open a PR to fix this up.

starbelly commented 2 years ago

This was closed via #28